GH-49638: [CI][Packaging][Python] Pin setuptools < 80 to build oldest pandas to test on musllinux#49639
GH-49638: [CI][Packaging][Python] Pin setuptools < 80 to build oldest pandas to test on musllinux#49639raulcd merged 5 commits intoapache:mainfrom
Conversation
…oldest pandas to test on musllinux
|
@github-actions crossbow submit wheel-musllinux-1-2-cp310-cp310-amd64 |
|
|
|
Revision: 1bd18f9 Submitted crossbow builds: ursacomputing/crossbow @ actions-fe5399c050
|
|
@github-actions crossbow submit wheel-musllinux-1-2-cp310-cp310-amd64 |
|
Revision: b63eefe Submitted crossbow builds: ursacomputing/crossbow @ actions-4231a95213
|
|
@github-actions crossbow submit wheel-musllinux-1-2-cp310-cp310-amd64 |
|
Revision: b2a5354 Submitted crossbow builds: ursacomputing/crossbow @ actions-ea82c70f0d
|
|
@github-actions crossbow submit wheel-musllinux-* |
|
Revision: b2a5354 Submitted crossbow builds: ursacomputing/crossbow @ actions-4f6a26815f
|
|
@AlenkaF I am thinking on merging this to fix CI for the release. We could bump the minimum version of numpy for Python 3.10 to fix this instead but given that this is going to be around only for 24.0.0 and 25.0.0, I think this is better. |
AlenkaF
left a comment
AlenkaF
left a comment
There was a problem hiding this comment.
LGTM 👍
(Also I learned something new - Constraints files and PIP_CONSTRAINT env var!)
|
Just one minor thing: we could add a note to remove this part once we bump the minimum version of numpy. A note could also be made on the issue for bumping numpy. |
github-actions
bot
added
awaiting review
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
github-actions
bot
added
awaiting review
Thanks @AlenkaF , I've done both, added a comment to the issue and to the code. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 75c8ede. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…oldest pandas to test on musllinux (apache#49639) ### Rationale for this change Musl Linux wheels for Python 3.10 fail to install due to newer setuptools not being able to build old pandas from source. The version of Pandas does not have Musl Linux wheels and is the last one to support the oldest numpy we support for Python 3.10. ### What changes are included in this PR? Pin old setuptools in case of Python 3.10 in order to be able to install old pandas from source. This will be deleted in a couple of releases once we drop support for Python 3.10. ### Are these changes tested? Yes via archery ### Are there any user-facing changes? No * GitHub Issue: apache#49638 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
3 participants
Rationale for this change
Musl Linux wheels for Python 3.10 fail to install due to newer setuptools not being able to build old pandas from source.
The version of Pandas does not have Musl Linux wheels and is the last one to support the oldest numpy we support for Python 3.10.
What changes are included in this PR?
Pin old setuptools in case of Python 3.10 in order to be able to install old pandas from source. This will be deleted in a couple of releases once we drop support for Python 3.10.
Are these changes tested?
Yes via archery
Are there any user-facing changes?
No